small changes to 3 adapter specs #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @PascalSalesch This PR should be hopefully merged soon. Can you temporarily remove your console.log updates and just make this PR be about the |
|
Hi @jsnellbaker I appreciate the review. I updated the PR accordingly. Unf. I'm not very familiar with how the testing env works but do you know why there was no |
jsnellbaker
approved these changes
Mar 4, 2020
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* muted adapter specs * updated scope of pr to global only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage should not be affected
Type of change
Description of change
Some adapters use console.log in their specs I wanted to silence their output.
in both cases it was bid objects with no useful purpose for the average user.
Another adapter used the literal pbjs-global, changed that to
getGlobal